Koulio / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Rietveld lists modified files as deleted. #84

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Upload something with deleted files.
2. Upload again when some of the deleted files have been changed to modified.

What is the expected output? What do you see instead?
Modified files are still marked as deleted, even though you can see them
via the View link or in the raw patch.

What version of the product are you using? On what operating system?
This is going through the Chromium development cycle using gcl, etc., on Hardy.

Please provide any additional information below.
Example: http://codereview.chromium.org/20056
The      
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/svg/W3C-SVG-1.1/tex
t-path-01-b-expected.checksum
file (about half way down) is marked "D" but you can see it is "M" but
clicking the View link, etc.

Original issue reported on code.google.com by dasthi@gmail.com on 4 Feb 2009 at 11:54

GoogleCodeExporter commented 9 years ago
Rietveld version is r378, btw.

Original comment by dasthi@gmail.com on 5 Feb 2009 at 12:02

GoogleCodeExporter commented 9 years ago
Is this repeatable with current r575?

Original comment by techtonik@gmail.com on 27 Sep 2010 at 5:35

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 7:35

GoogleCodeExporter commented 9 years ago
Still occurring at current revision on Chromium (October 2014).

See Patch Set 8 on https://codereview.chromium.org/598013003/.

Original comment by mgiuca@chromium.org on 2 Oct 2014 at 12:39

GoogleCodeExporter commented 9 years ago
Discovered a work-around: if you upload a new patch set which removes all 
changes to the file in question, and then another patch set which puts them 
back, Rietveld will discover that it is modified, not deleted. (See Patch Sets 
9 and 10 on the above CL.)

In any case, I doubt it would be a problem when submitting, as the raw diff is 
still correct.

Original comment by mgiuca@chromium.org on 2 Oct 2014 at 12:47