Kouzukii / ffxiv-characterstatus-refined

FFXIV Character Panel Refined - A Dalamud Plugin
MIT License
19 stars 11 forks source link

Crash with new CTRL functionality #11

Closed skulliemania closed 1 year ago

skulliemania commented 1 year ago

A friend and I both noticed that we crashed a couple of times when using ctrl to trigger our abilities. When we were diagnosing things it seems that this new CTRL functionality in the panel plugin is the only new thing that got updated.

Kouzukii commented 1 year ago

That's unfortunate. I had the version in testing for a while but hadn't experienced any crashed. Could you give me a few more details on how you can trigger the crash?

jcastrov commented 1 year ago

I also have this issue sometimes, when I have other apps open and then I come back to the game using a shortcut with Ctrl key modifier. Please note that the following steps to reproduce don't occur 100% of the time.

Steps to Reprode

  1. While FFXIV is running, open any other app and interact with it for some seconds.
  2. Go back to the game, and use a shortcut that has Ctrl key

    Expected Result

    I can see my Timers Modal (Ctrl + T is the shortcut I use)

    Actual Result

    A Dalamud modal warning shows up with several options to restart the game. If you click on the "Open Log" link, you may see the stack trace aiming at this addon (See Additional notes below).

    Technical Specifications

    • OS: Windows 10 Pro (Version 22H2) x64-based processor
    • Processor: Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz
    • RAM : 16.0 GB
    • Graphics Card: NVIDIA GeForce GTX 970
    • Character Panel Refined version: v1.6.0.0
    • XIVLaucner version: v6.2.44.0

      Additional notes

      
      Unhandled native exception occurred at ffxiv_dx11.exe+508C05
      Code: C0000005
      Dump at: C:\Users\username\AppData\Roaming\XIVLauncher\addon\Hooks\7.3.0.0\..\..\..\dalamud_appcrash_20221120_123739_102_8144.dmp
      Time: 2022-11-20 12:37:41.1172913 GMT-5

    at System.Environment.get_StackTrace()

    at Dalamud.EntryPoint.VehCallback() in C:\goatsoft\companysecrets\dalamud\EntryPoint.cs:line 70

    at FFXIVClientStructs.FFXIV.Component.GUI.AtkResNode.ToggleVisibility(Boolean enable) in D:\a\Dalamud\Dalamud\lib\FFXIVClientStructs\FFXIVClientStructs\FFXIVClientStructs.Generators\FFXIVClientStructs.Generators.FunctionGenerator.FunctionGenerator\FFXIVClientStructs.FFXIV.Component.GUI.AtkResNode.MemberFunctions.generated.cs:line 392

    at CharacterPanelRefined.CharacterPanelRefinedPlugin.UpdateCharacterPanelForJob(JobId job, Int32 lvl) in /work/repo/CharacterPanelRefined/CharacterPanelRefinedPlugin.cs:line 277

    at CharacterPanelRefined.CharacterPanelRefinedPlugin.CharacterStatusRequestUpdate(AtkUnitBase* atkUnitBase) in /work/repo/CharacterPanelRefined/CharacterPanelRefinedPlugin.cs:line 216

    at CharacterPanelRefined.CharacterPanelRefinedPlugin.FrameworkOnUpdate(Framework framework) in /work/repo/CharacterPanelRefined/CharacterPanelRefinedPlugin.cs:line 91

    at Dalamud.Utility.EventHandlerExtensions.HandleInvoke(Action act) in C:\goatsoft\companysecrets\dalamud\Utility\EventHandlerExtensions.cs:line 90

    at Dalamud.Utility.EventHandlerExtensions.InvokeSafely(OnUpdateDelegate updateDelegate, Framework framework) in C:\goatsoft\companysecrets\dalamud\Utility\EventHandlerExtensions.cs:line 82

    at Dalamud.Game.Framework.HandleFrameworkUpdate(IntPtr framework) in C:\goatsoft\companysecrets\dalamud\Game\Framework.cs:line 453

Kouzukii commented 1 year ago

The crash happens while the Character Panel is closed, right?

Kouzukii commented 1 year ago

I've rolled back to the previous version for now until I can reproduce the crash.