search

Kouzukii / ffxiv-deathrecap

FFXIV Plugin for showing death recaps
MIT License
19 stars 12 forks source link

“fixAndSig” #22

Closed tssailzz8 closed 2 years ago

tssailzz8 commented 2 years ago

https://github.com/Kouzukii/ffxiv-deathrecap/issues/21

Kouzukii commented 2 years ago

This is very similar to what I was planning on doing, thank you for your work. I'm currently on vacation and I'll take a closer look once I'm back

Kouzukii commented 2 years ago

I made a few adjustments to your code after testing it a bit, there does seem to be a few unusual interactions with lifesteal actions, but other than that it looks good.

Could you tell me where you took the signatures from? Or did you find them yourself

tssailzz8 commented 2 years ago

i do it by myself