search

Kouzukii / ffxiv-deathrecap

FFXIV Plugin for showing death recaps
MIT License
19 stars 12 forks source link

fix combateventcapture #35

Closed WINDOWCOLLAPSIBLE closed 6 months ago

WINDOWCOLLAPSIBLE commented 6 months ago

Fixed the classification of recovery as a HoT event when it is triggered by Kardion or Nascent Glint.

a3 = statusId source = iscrit

This is my first pull request so sorry if there are any problems.

Kouzukii commented 6 months ago

Thank you for your submission! There's a few formatting errors that I'll fix, but I'll do that in the main branch and just merge your changes as is for now.

Kouzukii commented 6 months ago

Actually, I've thought a bit more on it, what exactly would be the gain on having Kardion and Nascent Glint be shown separate from HoT effects? Especially Kardion triggers on every attack and I feel that would simply flood the log with unnecessary events.

WINDOWCOLLAPSIBLE commented 6 months ago

I thought about that too, but I thought it would be more realistic if I could actually see what the heal was coming from. Furthermore, the number of events displayed has not been changed as it only moves what is still displayed as HoT events to Heal events.

Kouzukii commented 6 months ago

Hm, I'm willing to give it a try