Kouzukii / ffxiv-priceinsight

A FFXIV Plugin to display marketboard prices on item tooltips
MIT License
17 stars 15 forks source link

Add the option to view the sale price of an entire stack #26

Closed WorkingRobot closed 1 year ago

WorkingRobot commented 1 year ago

While cleaning out my inventory, I often have the issue of wondering if it's worth the effort of putting the item on the market board. This option does the quick napkin math to show you how much the stack you are hovering over is worth if you were to put up your stack at that price. Suggestions are suggested; I'm not too sure of the wording still.

The item stack size is taken from tooltip text via regex. I'm not sure if there's a built-in into Dalamud way of finding it, outside of memory signatures or an InventoryTools dependency.

Configuration option: Configuration Window

Hovered example: Hovered Item Example

Kouzukii commented 1 year ago

Hey, thanks for your PR! I like your idea, but I'd certainly prefer getting the stacksize directly from memory rather than using a regex here (especially considering the Total might be different in each language). I'll have a look where to get this number and add it to your PR.

WorkingRobot commented 1 year ago

Oh yeah, that's totally fair, I don't know why I hadn't considered different languages. I couldn't find anyone else doing anything similar, let me know if you find anything about getting the stack size.