search

KovDimaY / Trip-Reviewer

This project was created to practice my full stack skills. It uses Mongo, React and Node with Express.
MIT License
2 stars 1 forks source link

DEV-60: change header layout for Desktop #107

Closed KovDimaY closed 6 years ago

KovDimaY commented 6 years ago

At the moment the layout of the header is the same for the desktop and mobile version:

image

As in the desktop case there are a lot of free space - it would be better to use it to show all the possible buttons at once as it usually happens for the headers with navigation:

image

To work on this issue, please use a branch DEV-60 created from devel. When the work is finished - create a PR to the devel branch. At the end of each development circles, code from the devel branch (if everything is ok) goes to the master branch and deploys to production.

IMPORTANT! Before creating a PR be sure that all the tests are passing and the coverage is 100%.

KovDimaY commented 6 years ago

Finally, the layout looks like this: 1) Not authenticated, Desktop:

image

2) Authenticated, Desktop:

image

For mobiles the layout stays the same: image

KovDimaY commented 6 years ago

Also it was requested to change the styles of the "Load More" button to be the same style as buttons of the header. So now the "Load More" button look like this:

image

KovDimaY commented 6 years ago

The PR is merged, the code is deployed to the PRE environment and tested. The issue can be closed.