KovDimaY / Trip-Reviewer

This project was created to practice my full stack skills. It uses Mongo, React and Node with Express.
MIT License
2 stars 1 forks source link

DEV-63: change layout for the SignUp page #113

Closed KovDimaY closed 6 years ago

KovDimaY commented 6 years ago

At the moment the signup page has the same logic of layout on the Desktop version and the Mobile - the form is on the top and the list of users is on the bottom:

image

As we are losing a lot of space with this layout, I think would be better to change it a bit for the desktop so we could use an advantage of the wide screen of the computer. In the end, I want to obtain something like this:

image

where on the right side is the list of users and it jumps to the bottom when the screen size decreases.

To work on this issue, please use a branch DEV-63 created from devel. When the work is finished - create a PR to the devel branch. At the end of each development circles, code from the devel branch (if everything is ok) goes to the master branch and deploys to production.

IMPORTANT! Before creating a PR be sure that all the tests are passing and the coverage is 100%

KovDimaY commented 6 years ago

Finally, the layout for the Desktop looks like this now:

image

When the width of the screen becomes less than 1050px - it changes to the same layout as it was before the fix. I made it with the purpose that if the screen is wide enough - we use an advantage of the horizontal space that we have, but if there is no enough space for the 3-avatars row - then makes no sense to have two columns and I change to the vertical layout as it was before. I think now it looks much better.

KovDimaY commented 6 years ago

The PR is merged, the code is deployed to the PRE environment, the issue can be closed.