KovDimaY / Trip-Reviewer

This project was created to practice my full stack skills. It uses Mongo, React and Node with Express.
MIT License
2 stars 1 forks source link

DEV-65: create a Button styled component #119

Open KovDimaY opened 6 years ago

KovDimaY commented 6 years ago

At the moment there are many buttons in the project which have very similar or sometimes just the same style (which is not simple- it has hove and active effect):

image

It leads to the code duplication and inconsistency throughout the project. Just look at this CSS:

image

It will be much easier, reusable and cleaner to have a separate component (styled component) which this logic encapsulated. As there are only 3 basic colors (green, orange and red) - the component can get have prop=type which will define completely the appearance of the button.

Keep in mind that there are two different types of buttons - BUTTON and BUTTON-LINK. We can create two different component for this purpose as they are not really the same. I think that with this change the project will become much cleaner and pleasant to work with.

To work on this issue, please use a branch DEV-65 created from devel. When the work is finished - create a PR to the devel branch. At the end of each development circles, code from the devel branch (if everything is ok) goes to the master branch and deploys to production.

IMPORTANT! Before creating a PR be sure that all the tests are passing and the coverage is 100%.