search

Kovah / LinkAce

LinkAce is a self-hosted archive to collect links of your favorite websites.
https://www.linkace.org
GNU General Public License v3.0
2.5k stars 159 forks source link

Fix minimum length password wording (character number) #792

Closed m0nhawk closed 2 months ago

m0nhawk commented 2 months ago

I noticed the actual wording is different than the actual behavior.

Wording says 10 characters limit: Screenshot from 2024-05-03 01-13-50

But the behavior is 8 characters. Screenshot from 2024-05-03 01-14-11

Kovah commented 2 months ago

Thanks for taking your time to fix these errors. Unfortunately, translations are handled in Crowdin and moving committed changes back into the translation system is more work than changing it there. If you have an account there and you're willing to redo it there, let me know. Otherwise I will make them myself.

m0nhawk commented 2 months ago

I missed that, I can update Crowdin through the weekend. 👍

m0nhawk commented 2 months ago

@Kovah I've submitted the Crowdin suggestions, and I think the en_US still needs to be fixed in code (and the tests).

Kovah commented 2 months ago

Awesome, many thanks!

Kovah commented 2 months ago

Hm, something doesn't seem right. Will have a look later.

m0nhawk commented 2 months ago

I noticed that the test was failing because of minimal character number in artisan cli, I have committed the fix - now it will match the other parts and 8 characters.