search

Kovalevskyi-Academy / Zeus

Other
2 stars 4 forks source link

W1D0 добавить проверку на Integer.MAX_VALUE в методе sqrt() класса NumberUtils #186

Closed Picallo-svg closed 5 months ago

seralekseenko commented 1 year ago

Заголовок отличный! Но без деталей — непонятно зачем это делать и пример бы сюда.

W25X80 commented 5 months ago

Due to integer overflow, the standard implementation of this method incorrectly processes the input Integer.MAX_VALUE. So i propose to add this case in test method + change sqrt method + add description to students task.

What do you think about that? Is this improvement actual ?