search

KovenYu / MAR

Pytorch code for our CVPR'19 (oral) work: Unsupervised person re-identification by soft multilabel learning
https://kovenyu.com/publication/2019-cvpr-mar/
315 stars 83 forks source link

Question about MDL loss in paper #23

Closed lambert1995 closed 5 years ago

lambert1995 commented 5 years ago

Hi, Thanks for your sharing. I have a question about your paper.

The equation (4) in 3.2. part 123

In P-bar, you calculate 2-norm of f(zi) - f(zj). According to content in 3.1. part, index pair (i, j) is found in the unlabeled target dataset X; intuitively, we should use image pair (xi, xj) to calculate 2-norm of f(xi) - f(xj).

So I wonder why you use (zi, zj), which is from an auxiliary RE-ID dataset Z, to calculate 2-norm in equation (4). Could you explain this? The same circumstances also happen in N-bar.

Thanks a lot !

KovenYu commented 5 years ago

Hi @lambert1995 , thanks for your attention! yes that's a subtle typo that we were not able to correct in the paper. your understanding is correct. it should be x instead of z.