search

KovtunV / NoStringEvaluating

Fast low memory consuming mathematical evaluation without endless string parsing! Parses string formula once and uses its object sequence in each evaluation. Moreover, provides user defined functions and variables.
MIT License
28 stars 10 forks source link

Implement scientific notation #22

Closed sebgerber closed 3 months ago

sebgerber commented 3 months ago

The goal of this Pull Request is to implement the possibility to use scentific notation as number.

At the moment, the value 4.2687556958921E-08 will be parse as -5.281718171540955 and not 0.000000042687556958921

@KovtunV Could you please have a look at it ? thx

KovtunV commented 3 months ago

Hi @sebgerber Thanks for the pull request, I will take a look. Could you update the branch, please?

sebgerber commented 3 months ago

Hi @KovtunV Thanks for the review. I have adapted the code accordingly

KovtunV commented 3 months ago

Hi @KovtunV Thanks for the review. I have adapted the code accordingly

Thanks! One more nitpick and we will merge

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.62%. Comparing base (1887e0b) to head (67b45ac).

Files Patch % Lines
...ating/Services/Parsing/NodeReaders/NumberReader.cs 86.95% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #22 +/- ## ======================================= Coverage 90.62% 90.62% ======================================= Files 186 186 Lines 2303 2303 Branches 421 421 ======================================= Hits 2087 2087 Misses 156 156 Partials 60 60 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KovtunV commented 3 months ago

I will publish new package or today or tomorrow, thanks!