KovtunV / NoStringEvaluating

Fast low memory consuming mathematical evaluation without endless string parsing! Parses string formula once and uses its object sequence in each evaluation. Moreover, provides user defined functions and variables.
MIT License
28 stars 10 forks source link

Support for unknown variables #4

Closed IvoTops closed 2 years ago

IvoTops commented 2 years ago

Implemented support for getting no value for a variable and treating it as null. Evaluating x + y will be null if either x or y is unknown and not throw an error anymore.

Documentation is not yet updated

IvoTops commented 2 years ago

Ok, will fix. Is there an easy way to get the same settings in my visual studio?

On Sun, 17 Jul 2022 at 21:02, Vitaly @.***> wrote:

@.**** requested changes on this pull request.

Can't review other files until you fix namespace design

In NoStringEvaluating.Extensions.Microsoft.DependencyInjection/NoStringEvaluating.Extensions.Microsoft.DependencyInjection.csproj https://github.com/KovtunV/NoStringEvaluating/pull/4#discussion_r922882385 :

@@ -37,4 +36,8 @@

Don't change this file pls, it should refer to nuget

In NoStringEvaluating/Contract/INoStringEvaluator.cs https://github.com/KovtunV/NoStringEvaluating/pull/4#discussion_r922882650 :

@@ -5,416 +5,417 @@ using NoStringEvaluating.Models.Values; using NoStringEvaluating.Nodes.Common;

-namespace NoStringEvaluating.Contract;

-///

-/// Expression evaluator -/// -public interface INoStringEvaluator +namespace NoStringEvaluating.Contract

Don't change design for namespaces, please, fix in all files. Have you rebased successfully?

— Reply to this email directly, view it on GitHub https://github.com/KovtunV/NoStringEvaluating/pull/4#pullrequestreview-1041172708, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5YHTTOTPZMZXSZ4BQNEFLVURKFZANCNFSM532DWHSQ . You are receiving this because you authored the thread.Message ID: @.***>

KovtunV commented 2 years ago

Ok, will fix. Is there an easy way to get the same settings in my visual studio?

To change namespace design? Yes, it should be in Visual Studio

IvoTops commented 2 years ago

To rebase I fetched upstream from the master and that has the 'old' namespace design. If I change the namespace design in visual studio and apply that it will also apply all my other code formatting settings. I see no option in vs to selectively apply only the namespace design change. Could you run your coding style settings over the pull request and re-commit?

IvoTops commented 1 year ago

If you think that works better please do that. I have been on GitHub for a while but have only recently started contributing and using PR and such.

On Fri, Jul 22, 2022, 07:42 Vitaly @.***> wrote:

To rebase I fetched upstream from the master and that has the 'old' namespace design. If I change the namespace design in visual studio and apply that it will also apply all my other code formatting settings. I see no option in vs to selectively apply only the namespace design change. Could you run your coding style settings over the pull request and re-commit?

is it possible? Think will make MR to your master branch with these fixes

— Reply to this email directly, view it on GitHub https://github.com/KovtunV/NoStringEvaluating/pull/4#issuecomment-1192204041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5YHTVSKOWO2CHMONC6EALVVIYDLANCNFSM532DWHSQ . You are receiving this because you authored the thread.Message ID: @.***>