search

Kowson / Details-Damage-Meter-for-3.3.5a

Details Damage Meter backported for World of Warcraft 3.3.5a Wrath of the Lich King
32 stars 14 forks source link

[BUG] Shaman Fire elemental & Unholy DK Ghoul are not shown under their owner #30

Open HamonTim opened 4 years ago

HamonTim commented 4 years ago

Hello,

The damage from Fire elemental/Earth elemental/DK Ghoul are not shown in the dps meters.

Patchwerk_Combat_Log.txt

I attached a WoWCombatLog on Patchwerk where there was only one Ghoul and one Fire Elemental if it can help.

HamonTim commented 4 years ago

Here the log uploaded to world of logs if it can help http://www.worldoflogs.com/reports/w3i2w39k79l61dhk/analyze/dd/source/?s=205&e=353

Kowson commented 4 years ago

Sure it will, I will take look into this in. Thanks

kingwersen commented 3 years ago

Both Recount and Skada also fail to record shaman elementals in 3.3.5. The problem is that the combat log events for summoning the elemental and the totem (the elemental's owner) are provided in the wrong order. When the elemental is spawned, it provides the totem's GUID, but since the totem hasn't spawned yet the addon fails to register the elemental. More information: https://www.wowace.com/projects/recount/issues/532

Recount's Cataclysm fix (which works in 3.3.5) is the following: RecountPatch.txt. I've made a corresponding fix for Details: parser.lua.patch

I had to comment out some conflicting logic to get it to work. We'll need to find a reasonable way to support it, assuming it isn't also just an attempt to fix the shaman elemental bug.