search

Kowson / Details-Damage-Meter-for-3.3.5a

Details Damage Meter backported for World of Warcraft 3.3.5a Wrath of the Lich King
32 stars 14 forks source link

Absorbs not being tracking correctly. #7

Open Krealle opened 4 years ago

Krealle commented 4 years ago

Absorbs are not being tracked correctly. Only full absorbs(misses) appear to be tracked correctly.

The issue seems to appear occasionally on partial absorbs. Leaving spells like PW:shield to only track 60-70% of the time, and Sacred Shield track anywhere from 50%-200% of absorb it should.

I can't seem to figure out whats causing it besides that it has something to do with partial absorbs.

andrew6180 commented 4 years ago

not sure about this branch since I've re-implemented shield tracking on mine, but the issue comes from the order of events in wotlk. Wotlk first removes the buff for the shield, then applies the damage and passes how much was absorbed. I fixed it in this commit https://github.com/ajseward/Details-Damage-Meter-for-3.3.5a/commit/1f73338cea58669ed29620595ef845d8ead3deb6 which should fix disc issues.

I'm unsure why sacred shield tracks for more than it should.

Krealle commented 4 years ago

Will have to try that out, might fix sacred shield tracking as well.

AFKoncore commented 4 years ago

Val'anyr Hammer of the Ancient Kings have the same issue. It's the big thing preventing me from dropping Skada atm

Kowson commented 4 years ago

I need combat log and/or worldoflogs to fix that if u can provide that.

AFKoncore commented 4 years ago

Which addon should I use to do that? I get the impression AutoLog is just to turn on the recording, not to do the recording itself

Kowson commented 4 years ago

For first one write /combatlog before fight and disable it after fight, it will save it in Logs folder in WoW direcotry as WoWCombatLog.txt as far as I remember. For second one your guild should gather it, I don't really know how is it done (check http://worldoflogs.com/).

PS. Also I've heard opinions that Skada doesn't work with Val'anyr, and my addon may be actually closer to the true amount, but it needs to be confirmed.

AFKoncore commented 4 years ago

Is something like this (duel) good enough or you prefer a real raid? https://pastebin.com/CkVnatfx

Kowson commented 4 years ago

And how much Details! shows?

AFKoncore commented 4 years ago

Sorry for the delay, here we go: World of Logs: http://www.worldoflogs.com/reports/ed9rq90ckkadu559/sum/healingDone/?s=247&e=366 Raw combat log: https://www.mediafire.com/file/4k2n2jdet9i9dtp/ Comparison Skada/Details! (for Tovaron): https://i.imgur.com/Uow5HYX.png

Skada seems to over estimate a bit and Details! to underestimate, it looks better than I initially thought. I'll log & compare over the course of a proper raid next time I do one.

Kowson commented 4 years ago

Thanks for the logs, but I'm afraid that it isn't possible to track exact absorb amounts, all addons like Details and Skada need to guess which shield absorbed what, that's where the differences come from. Personally I encourage you to test and compare results of incoming raids. I just am quite sure that Skada prefers to choose Val'anyr's shield before disci priest shield, which should work other way, because PW: Shield is main source of shields usually. It is best seen if you have any resto druid with Val'anyr and disci priest in same raid, Skada sometimes actually shows that druid absorbed more damage than disci priest :D

AFKoncore commented 4 years ago

I believe the last shield applied is absorbed first, and as under Val'anyr any heal reapply Protection of the Ancient Kings it would be a good guess