search

Kozea / pygal

PYthon svg GrAph plotting Library
https://www.pygal.org
GNU Lesser General Public License v3.0
2.64k stars 411 forks source link

Add importlib_metadata as a real dependency for now #548

Closed akx closed 10 months ago

akx commented 10 months ago

This is an alternate take to #546 that will make this package installable in general without having to specify importlib_metadata as a downstream dependency.

Using importlib.metadata directly (as implemented in #546) is the better solution, but this should allow for releasing a 3.0.4 as a stopgap measure.

akx commented 10 months ago

cc @gentooboontoo, if you want to release a 3.0.4 today before I get CI up and running and get a better fix in.

I locally tested that this builds a correct wheel that has the correct dependency:

$ unzip -p dist/pygal-3.0.3-py2.py3-none-any.whl pygal-3.0.3.dist-info/METADATA | grep -C5 importli
Classifier: Topic :: Multimedia :: Graphics :: Presentation
Provides: pygal
Requires-Python: >=3.8
Description-Content-Type: text/x-rst
License-File: COPYING
Requires-Dist: importlib-metadata
Provides-Extra: docs
Requires-Dist: sphinx ; extra == 'docs'
Requires-Dist: sphinx-rtd-theme ; extra == 'docs'
Requires-Dist: pygal-sphinx-directives ; extra == 'docs'
Provides-Extra: lxml
gentooboontoo commented 10 months ago

Thanks. I have already added install_requires in 0a798386ab66bff7c1c92adc1797ed6ba3d0e2d0 but without a comment and I also forgot to remove importlib_metadata from tox.ini so PR rebased and merged :wink: