Closed misuzu closed 4 years ago
Tests is failing with recent pytest-flake8:
pytest-flake8
$ virtualenv -p python3 venv && . venv/bin/activate && python setup.py test running pytest Searching for webencodings>=0.4 Reading https://pypi.org/simple/webencodings/ Downloading https://files.pythonhosted.org/packages/f4/24/2a3e3df732393fed8b3ebf2ec078f05546de641fe1b667ee316ec1dcf3b7/webencodings-0.5.1-py2.py3-none-any.whl#sha256=a0af1213f3c2226497a97e2b3aa01a7e4bee4f403f95be16fc9acd2947514a78 Best match: webencodings 0.5.1 Processing webencodings-0.5.1-py2.py3-none-any.whl Installing webencodings-0.5.1-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/webencodings-0.5.1-py3.7.egg Searching for pytest-isort Reading https://pypi.org/simple/pytest-isort/ Downloading https://files.pythonhosted.org/packages/48/71/fa0aa9b78bbc9d0855b4db6c69c8eb1ef198eac8d1cbfc011cc02a9973ca/pytest_isort-1.0.0-py2.py3-none-any.whl#sha256=5d47dd4c45a7c2eb4a0401ae4febe143724dd8a2acf1e7317c80145bac8b608a Best match: pytest-isort 1.0.0 Processing pytest_isort-1.0.0-py2.py3-none-any.whl Installing pytest_isort-1.0.0-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/pytest_isort-1.0.0-py3.7.egg Searching for pytest-flake8 Reading https://pypi.org/simple/pytest-flake8/ Downloading https://files.pythonhosted.org/packages/bd/6a/7d1eff6426ab087e7bc6d47328765205dbc29bea2e994c1c7f46409ae7cf/pytest_flake8-1.0.6-py2.py3-none-any.whl#sha256=2e91578ecd9b200066f99c1e1de0f510fbb85bcf43712d46ea29fe47607cc234 Best match: pytest-flake8 1.0.6 Processing pytest_flake8-1.0.6-py2.py3-none-any.whl Installing pytest_flake8-1.0.6-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/pytest_flake8-1.0.6-py3.7.egg Searching for pytest-cov Reading https://pypi.org/simple/pytest-cov/ Downloading https://files.pythonhosted.org/packages/3d/13/ae3dec587b1cc07fb9f294e52ea9ad140266aea55adb9e12eade3625bd27/pytest_cov-2.10.0-py2.py3-none-any.whl#sha256=6e6d18092dce6fad667cd7020deed816f858ad3b49d5b5e2b1cc1c97a4dba65c Best match: pytest-cov 2.10.0 Processing pytest_cov-2.10.0-py2.py3-none-any.whl Installing pytest_cov-2.10.0-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/pytest_cov-2.10.0-py3.7.egg Searching for pytest>=3.5 Reading https://pypi.org/simple/pytest/ Downloading https://files.pythonhosted.org/packages/9f/f3/0a83558da436a081344aa6c8b85ea5b5f05071214106036ce341b7769b0b/pytest-5.4.3-py3-none-any.whl#sha256=5c0db86b698e8f170ba4582a492248919255fcd4c79b1ee64ace34301fb589a1 Best match: pytest 5.4.3 Processing pytest-5.4.3-py3-none-any.whl Installing pytest-5.4.3-py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/pytest-5.4.3-py3.7.egg Searching for isort>=4.0 Reading https://pypi.org/simple/isort/ Downloading https://files.pythonhosted.org/packages/e5/b0/c121fd1fa3419ea9bfd55c7f9c4fedfec5143208d8c7ad3ce3db6c623c21/isort-4.3.21-py2.py3-none-any.whl#sha256=6e811fcb295968434526407adb8796944f1988c5b65e8139058f2014cbe100fd Best match: isort 4.3.21 Processing isort-4.3.21-py2.py3-none-any.whl Installing isort-4.3.21-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/isort-4.3.21-py3.7.egg Searching for flake8>=3.5 Reading https://pypi.org/simple/flake8/ Downloading https://files.pythonhosted.org/packages/6c/20/6326a9a0c6f0527612bae748c4c03df5cd69cf06dfb2cf59d85c6e165a6a/flake8-3.8.3-py2.py3-none-any.whl#sha256=15e351d19611c887e482fb960eae4d44845013cc142d42896e9862f775d8cf5c Best match: flake8 3.8.3 Processing flake8-3.8.3-py2.py3-none-any.whl Installing flake8-3.8.3-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/flake8-3.8.3-py3.7.egg Searching for coverage>=4.4 Reading https://pypi.org/simple/coverage/ Downloading https://files.pythonhosted.org/packages/0d/85/b055f9c1a210f0c7e16e675b286ce4e16d80ba4c4e566de143e8d58dd7f2/coverage-5.1-cp37-cp37m-manylinux1_x86_64.whl#sha256=adeb4c5b608574a3d647011af36f7586811a2c1197c861aedb548dd2453b41cd Best match: coverage 5.1 Processing coverage-5.1-cp37-cp37m-manylinux1_x86_64.whl Installing coverage-5.1-cp37-cp37m-manylinux1_x86_64.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/coverage-5.1-py3.7-linux-x86_64.egg Searching for wcwidth Reading https://pypi.org/simple/wcwidth/ Downloading https://files.pythonhosted.org/packages/ef/94/a17155b400812f0558093c6fb99f92ba823e24757d5884e3ec60f5e81319/wcwidth-0.2.4-py2.py3-none-any.whl#sha256=79375666b9954d4a1a10739315816324c3e73110af9d0e102d906fdb0aec009f Best match: wcwidth 0.2.4 Processing wcwidth-0.2.4-py2.py3-none-any.whl Installing wcwidth-0.2.4-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/wcwidth-0.2.4-py3.7.egg Searching for py>=1.5.0 Reading https://pypi.org/simple/py/ Downloading https://files.pythonhosted.org/packages/ae/12/76710702ccf77dab01246ecb55fbe43175131c0738d0be29f3de50d31071/py-1.8.2-py2.py3-none-any.whl#sha256=a673fa23d7000440cc885c17dbd34fafcb7d7a6e230b29f6766400de36a33c44 Best match: py 1.8.2 Processing py-1.8.2-py2.py3-none-any.whl Installing py-1.8.2-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/py-1.8.2-py3.7.egg Searching for pluggy<1.0,>=0.12 Reading https://pypi.org/simple/pluggy/ Downloading https://files.pythonhosted.org/packages/a0/28/85c7aa31b80d150b772fbe4a229487bc6644da9ccb7e427dd8cc60cb8a62/pluggy-0.13.1-py2.py3-none-any.whl#sha256=966c145cd83c96502c3c3868f50408687b38434af77734af1e9ca461a4081d2d Best match: pluggy 0.13.1 Processing pluggy-0.13.1-py2.py3-none-any.whl Installing pluggy-0.13.1-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/pluggy-0.13.1-py3.7.egg Searching for packaging Reading https://pypi.org/simple/packaging/ Downloading https://files.pythonhosted.org/packages/46/19/c5ab91b1b05cfe63cccd5cfc971db9214c6dd6ced54e33c30d5af1d2bc43/packaging-20.4-py2.py3-none-any.whl#sha256=998416ba6962ae7fbd6596850b80e17859a5753ba17c32284f67bfff33784181 Best match: packaging 20.4 Processing packaging-20.4-py2.py3-none-any.whl Installing packaging-20.4-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/packaging-20.4-py3.7.egg Searching for more-itertools>=4.0.0 Reading https://pypi.org/simple/more-itertools/ Downloading https://files.pythonhosted.org/packages/ef/9b/6c35ec5483710492e21252465160ee508170159f7e0e2d6cd769022f52f6/more_itertools-8.4.0-py3-none-any.whl#sha256=b78134b2063dd214000685165d81c154522c3ee0a1c0d4d113c80361c234c5a2 Best match: more-itertools 8.4.0 Processing more_itertools-8.4.0-py3-none-any.whl Installing more_itertools-8.4.0-py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/more_itertools-8.4.0-py3.7.egg Searching for importlib-metadata>=0.12 Reading https://pypi.org/simple/importlib-metadata/ Downloading https://files.pythonhosted.org/packages/98/13/a1d703ec396ade42c1d33df0e1cb691a28b7c08b336a5683912c87e04cd7/importlib_metadata-1.6.1-py2.py3-none-any.whl#sha256=15ec6c0fd909e893e3a08b3a7c76ecb149122fb14b7efe1199ddd4c7c57ea958 Best match: importlib-metadata 1.6.1 Processing importlib_metadata-1.6.1-py2.py3-none-any.whl Installing importlib_metadata-1.6.1-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/importlib_metadata-1.6.1-py3.7.egg Searching for attrs>=17.4.0 Reading https://pypi.org/simple/attrs/ Downloading https://files.pythonhosted.org/packages/a2/db/4313ab3be961f7a763066401fb77f7748373b6094076ae2bda2806988af6/attrs-19.3.0-py2.py3-none-any.whl#sha256=08a96c641c3a74e44eb59afb61a24f2cb9f4d7188748e76ba4bb5edfa3cb7d1c Best match: attrs 19.3.0 Processing attrs-19.3.0-py2.py3-none-any.whl Installing attrs-19.3.0-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/attrs-19.3.0-py3.7.egg Searching for pyflakes<2.3.0,>=2.2.0 Reading https://pypi.org/simple/pyflakes/ Downloading https://files.pythonhosted.org/packages/69/5b/fd01b0c696f2f9a6d2c839883b642493b431f28fa32b29abc465ef675473/pyflakes-2.2.0-py2.py3-none-any.whl#sha256=0d94e0e05a19e57a99444b6ddcf9a6eb2e5c68d3ca1e98e90707af8152c90a92 Best match: pyflakes 2.2.0 Processing pyflakes-2.2.0-py2.py3-none-any.whl Installing pyflakes-2.2.0-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/pyflakes-2.2.0-py3.7.egg Searching for pycodestyle<2.7.0,>=2.6.0a1 Reading https://pypi.org/simple/pycodestyle/ Downloading https://files.pythonhosted.org/packages/10/5b/88879fb861ab79aef45c7e199cae3ef7af487b5603dcb363517a50602dd7/pycodestyle-2.6.0-py2.py3-none-any.whl#sha256=2295e7b2f6b5bd100585ebcb1f616591b652db8a741695b3d8f5d28bdc934367 Best match: pycodestyle 2.6.0 Processing pycodestyle-2.6.0-py2.py3-none-any.whl Installing pycodestyle-2.6.0-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/pycodestyle-2.6.0-py3.7.egg Searching for mccabe<0.7.0,>=0.6.0 Reading https://pypi.org/simple/mccabe/ Downloading https://files.pythonhosted.org/packages/87/89/479dc97e18549e21354893e4ee4ef36db1d237534982482c3681ee6e7b57/mccabe-0.6.1-py2.py3-none-any.whl#sha256=ab8a6258860da4b6677da4bd2fe5dc2c659cff31b3ee4f7f5d64e79735b80d42 Best match: mccabe 0.6.1 Processing mccabe-0.6.1-py2.py3-none-any.whl Installing mccabe-0.6.1-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/mccabe-0.6.1-py3.7.egg Searching for six Reading https://pypi.org/simple/six/ Downloading https://files.pythonhosted.org/packages/ee/ff/48bde5c0f013094d729fe4b0316ba2a24774b3ff1c52d924a8a4cb04078a/six-1.15.0-py2.py3-none-any.whl#sha256=8b74bedcbbbaca38ff6d7491d76f2b06b3592611af620f8426e82dddb04a5ced Best match: six 1.15.0 Processing six-1.15.0-py2.py3-none-any.whl Installing six-1.15.0-py2.py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/six-1.15.0-py3.7.egg Searching for pyparsing>=2.0.2 Reading https://pypi.org/simple/pyparsing/ Downloading https://files.pythonhosted.org/packages/a4/9f/868e59e76cbeea46fe5b49197412f0b58fb975eec0bc16d567b8454c1a6f/pyparsing-3.0.0a1-py3-none-any.whl#sha256=67199f0c41a9c702154efb0e7a8cc08accf830eb003b4d9fa42c4059002e2492 Best match: pyparsing 3.0.0a1 Processing pyparsing-3.0.0a1-py3-none-any.whl Installing pyparsing-3.0.0a1-py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/pyparsing-3.0.0a1-py3.7.egg Searching for zipp>=0.5 Reading https://pypi.org/simple/zipp/ Downloading https://files.pythonhosted.org/packages/b2/34/bfcb43cc0ba81f527bc4f40ef41ba2ff4080e047acb0586b56b3d017ace4/zipp-3.1.0-py3-none-any.whl#sha256=aa36550ff0c0b7ef7fa639055d797116ee891440eac1a56f378e2d3179e0320b Best match: zipp 3.1.0 Processing zipp-3.1.0-py3-none-any.whl Installing zipp-3.1.0-py3-none-any.whl to /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs Installed /home/misuzu/Workspace/Projects/Other/tinycss2/.eggs/zipp-3.1.0-py3.7.egg running egg_info creating tinycss2.egg-info writing tinycss2.egg-info/PKG-INFO writing dependency_links to tinycss2.egg-info/dependency_links.txt writing requirements to tinycss2.egg-info/requires.txt writing top-level names to tinycss2.egg-info/top_level.txt writing manifest file 'tinycss2.egg-info/SOURCES.txt' reading manifest file 'tinycss2.egg-info/SOURCES.txt' writing manifest file 'tinycss2.egg-info/SOURCES.txt' running build_ext ===================================================================== test session starts ===================================================================== platform linux -- Python 3.7.7, pytest-5.4.3, py-1.8.2, pluggy-0.13.1 rootdir: /home/misuzu/Workspace/Projects/Other/tinycss2, inifile: setup.cfg plugins: cov-2.10.0, flake8-1.0.6, isort-1.0.0 collected 502 items setup.py .. [ 0%] docs/conf.py .. [ 0%] docs/css_diagram_role.py .. [ 1%] tinycss2/__init__.py .. [ 1%] tinycss2/ast.py .. [ 1%] tinycss2/bytes.py .. [ 2%] tinycss2/color3.py .. [ 2%] tinycss2/nth.py .. [ 3%] tinycss2/parser.py .. [ 3%] tinycss2/serializer.py .. [ 3%] tinycss2/test_tinycss2.py ............................................................................................................................. [ 28%] ....................................................................................................................................................... [ 58%] ....................................................................................................................................................... [ 89%] ................................................. [ 98%] tinycss2/tokenizer.py .. [ 99%] tinycss2/css-parsing-tests/make_color3_hsl.py .F [ 99%] tinycss2/css-parsing-tests/make_color3_keywords.py .. [100%] ========================================================================== FAILURES =========================================================================== ________________________________________________________________________ FLAKE8-check _________________________________________________________________________ /home/misuzu/Workspace/Projects/Other/tinycss2/tinycss2/css-parsing-tests/make_color3_hsl.py:19:9: E741 ambiguous variable name 'l' ---------------------------------------------------------------------- Captured log call ---------------------------------------------------------------------- WARNING flake8.options.manager:manager.py:211 option --max-complexity: please update from optparse string `type=` to argparse callable `type=` -- this will be an error in the future =================================================================== short test summary info =================================================================== FAILED tinycss2/css-parsing-tests/make_color3_hsl.py::FLAKE8 ================================================================ 1 failed, 501 passed in 2.03s ================================================================
This patch should fix above error and hopefully make code more readable.
Thank you :heart:!
liZe
commented
4 years ago liZe
commented
4 years ago
Tests is failing with recent
pytest-flake8:This patch should fix above error and hopefully make code more readable.