search

Kozinak196 / emweather

Automatically exported from code.google.com/p/emweather
0 stars 0 forks source link

Various types of rain have misleading icons #19

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Wait for week with rainy days
2. Compare the icons to the tooltips

What is the expected output? What do you see instead?
Expected: "Rain" to have more little droplets below the little cloud than 
"Showers." This is not the case.

What version of EmWeather are you using? What is your OS API?
Latest on the market for Eclair. 

Please provide any additional information below.

I know, it's a whiny little issue having to do with parsing the ill-defined 
weather strings that EC provides, I've used their feeds before. I'm mostly 
reporting it because it's a simple little issue that I wouldn't mind 
contributing my time to fix. Are you accepting code contributions?

Original issue reported on code.google.com by adamb...@gmail.com on 1 Dec 2010 at 12:26

GoogleCodeExporter commented 8 years ago 
Hello, thanks for the bug report.

You are very welcome to have a look at the code and submit patch for the 
weather icon maps.  I appreciate the offer!  For the sources, use the latest 
tarball found on the downloads page.

Some details to help get oriented:

- it's important which icon-set you are using.  Only the environment canada 
icon set can be expected to perfectly match with the weather forecast.  All the 
other sets were created for weather.com forecasts and so may not correspond to 
Environment Canada forecasts.  On top of that, not all the icon sets HAVE 
different icons for all different types of forecasts, this depends on the 
artist, not on me.

- There are two cases.  One is the user is using the environment canada icon 
set (which has it's own mappings) OR they are using a weather.com style icon 
set.

- You will find the icon-mappings easy to change.  They are found in 
IconMap.java.  There are 3 HashMaps you may need to consider.  Probably you 
will want to look at the first one.

  1. icon_hash_map => This is what maps each weather icon number to the appropriate type of weather icon (look in the resource directory to see all the weather icons and their numbers).  Again, there are two cases, either it's the environment canada icon set or a weather.com style icon set.

  2. env_canada_current_map => This maps every possible Environment Canada "current conditions" forecast to the appropriate weather icon type

  3. env_canada_forecast_map => This maps every possible Environment Canada "forecast conditions" forecast to the appropriate weather icon type.

  Note: the fourth map, weather_com_int_map is something I wrote to plug in weather.com style xml forecasts into the program (similar to 2 and 3 above).  It is NOT currently in use (weather.com charges immense amounts of money for their weather feeds).

Please let me know if you need any more help!

Original comment by emweat...@gmail.com on 1 Dec 2010 at 5:45

GoogleCodeExporter commented 8 years ago 
ps. If there are any artists out there who wish to make a custom icon set for 
EmWeather, I would be super excited to talk with you about it!

Original comment by emweat...@gmail.com on 1 Dec 2010 at 5:46

GoogleCodeExporter commented 8 years ago 
Hi Guy,

I went through the IconMap.java file and updated some of the mappings. I've
attached a patch file with those changes, and some list reformatting that my
OCD fingers wouldn't let slide.

Most of the changes were regarding rain vocabulary. According to me (and
verified by wikipedia), the heirarchy of rain words from light to heavy
goes: "drizzle" < "showers" < "rain".  Previously, 'drizzle' seemed to be
treated as heavy rain.  Same thing with 'Flurries' < 'Snow.' Broadly, a lot
of HEAVY things were downgraded.

I think these changes should address the issue I submitted. Sorry I didn't
do more, I wasn't prepared to do much more than this without having
installed the Android SDK to test the changes out.

Thanks again for the great app, and I hope to contribute more later.

Original comment by adamb...@gmail.com on 8 Dec 2010 at 6:57

GoogleCodeExporter commented 8 years ago 
Hi,

Thanks for the submission, I was going to look at your patch and integrate it 
tonight but I don't see the patch file, did you attach it?  Can you please 
attach it again.

You are right that I treated drizzle as heavy rain, my mistake, thanks for the 
correction.  Looking forward to seeing the patch.

Emilie

Original comment by emweat...@gmail.com on 10 Dec 2010 at 1:45

GoogleCodeExporter commented 8 years ago 
Hi Emilie,

Here's a link to the patch in dropbox.

http://dl.dropbox.com/u/182152/weather-mappings-updated2.patch

Original comment by adamb...@gmail.com on 10 Dec 2010 at 3:40

GoogleCodeExporter commented 8 years ago 
This has been added in 0.9.5.1.  Thanks again for the help.

Original comment by emweat...@gmail.com on 21 Feb 2011 at 6:55