Kqzz / MCsniperGO

MCsniperGO, a fast, efficient, and feature-packed minecraft name sniper.

https://mcsniperpy.com

187 stars 37 forks source link

Replaced the 5 log functions with a single one and a hashmap/map. #10

Closed talwat closed 2 years ago

talwat commented 2 years ago

Pull Request

PR status

[x] Pull request changes made
[x] Code reviewed
[x] Code merged

Proposed changes

There are 5 log functions, and I simply shrunk them down to one. Now, it's easier to add new log types, and easier to edit the existing log prefixes. You just do `log(message, logType).` ## Related issues

Notes from author

talwat commented 2 years ago

@Kqzz I fixed some of the issues. Regarding the extra parameters, some of the log commands dont include the extra options, and If I moved it then the formatting options would no longer be optional when calling the function.

Kqzz commented 2 years ago

there some things i’d like to change, which i’ll do tomorrow, but overall great changes!

overestimate commented 2 years ago

there some things i’d like to change, which i’ll do tomorrow, but overall great changes!

"i'll do [it] tomorrow" - kqzz, oct 20, 2021 date of posting is oct 24, 2021. congrats!

Kqzz commented 2 years ago

there some things i’d like to change, which i’ll do tomorrow, but overall great changes!

"i'll do [it] tomorrow" - kqzz, oct 20, 2021 date of posting is oct 24, 2021. congrats!

Thanks! I'm very on top of this if you couldn't tell.

Kqzz commented 2 years ago

looks ready to merge, I'll just have to run it locally to confirm it's functioning.