search

Kr0oked / Metronome

Simple and beautiful metronome for Android
GNU General Public License v3.0
84 stars 10 forks source link

Remove BPM limits when entering with keyboard or +/- buttons #11

Open ggttttggggtt opened 1 year ago

ggttttggggtt commented 1 year ago

Though rare, there is music slower than 40 and faster than 208 BPM.

Kr0oked commented 1 year ago

For the moment I will keep the current range. Unfortunately it gets harder to select a specific value on the slider when the range is bigger. So I think it is more important to easily select common tempos then allow very slow or very fast tempos.

ggttttggggtt commented 1 year ago

On my phone it lets me select the BPM text box here, and the keyboard comes up, but input is blocked. I think it would be great if we can type a BPM outside of the limits, and wouldn't clutter the slider. image

luzidd commented 1 year ago

I also think it would be good to have arbitrary bpm limits. Maybe have the values for MIN & MAX configurable in the Settings.

Kr0oked commented 1 year ago

I also think it would be good to have arbitrary bpm limits. Maybe have the values for MIN & MAX configurable in the Settings.

I like the approach with the settings, maybe I will implement it that way

ksdrummer commented 1 year ago

Hi, I'm trying this metronome. It's great but I do practice with very slow metronome and it's essential to me. I play sometimes with metronomes at 3bpm. It's frustrating that so few metronomes allow this. Just came here to say that it would make it really great to have this possibility. The settings options looks perfect Again thank you for this promising metronome

Rstment25 commented 10 months ago

Please fix this, let us set the limits / bpm manually...

Kr0oked commented 9 months ago

I decided against implementing an arbitrary tempo selection. From a technical perspective and also from the UI perspective I want to have a consistent model. The slider, input field and the buttons should allow the exact same values.

But I acknowledge that the tempo range from 40-208 bmp is too small for some scenarios. These values were adopted from the range of classical mechanical metronomes.

In the latest release 1.4.5 I extended the range to 30-252 bpm. Now I adopted the tempo range from a modern commercial grade metronome, the Korg KDM-3.

ksdrummer commented 9 months ago

Hi, thank you for letting us know.

As a professional musician I know it's not rare at all to use metronome below this limit, I do it every day and many of my friends, my students also do it. In my opinion, it just makes you app limited... what makes this app different from the other ones if it doesn't offer anything more intersting to the users?

But I respect you choice, and wish you the best, I love the look and feel of this metronome.

For those who need a range below 30 BPM, I strongly recommend Chubby Click from f-droid. It's been my main metronome for a while now.

Rstment25 commented 9 months ago

I decided against implementing an arbitrary tempo selection. From a technical perspective and also from the UI perspective I want to have a consistent model. The slider, input field and the buttons should allow the exact same values.

But I acknowledge that the tempo range from 40-208 bmp is too small for some scenarios. These values were adopted from the range of classical mechanical metronomes.

In the latest release 1.4.5 I extended the range to 30-252 bpm. Now I adopted the tempo range from a modern commercial grade metronome, the Korg KDM-3.

Ok but why?

It makes your app unsightly or something along those lines?

Why replicate it 1to1? Why not make something better...

*Lot of apps deal with this problem by simply letting you type out any arbitrary value.

When you grab the slider if the value is outside of it's set range it simply changes it to the next closest value within the range - like say my bpm is 1 , I grab the slider it instantly changes value to 30 and then allows finer tunings by dragging it

Kr0oked commented 9 months ago

Yes, one of my concerns is that the "simple" operability suffers. And I dont think limitations are a bad thing. Actually the app is better if the values are limited to the ones needed for a metronom. The app is not a toy but a tool for a specific use case.

If I allow a tempo of 900 bpm you sure have more freedom, but you also have a noise generator and not a metronom.

droid192 commented 5 months ago

please let the user go below 30; wonder to fork & publish .. https://github.com/Kr0oked/Metronome/blob/da48852b1d59b355a08543f4e5b69e153109c39e/app/src/main/java/com/bobek/metronome/data/Tempo.kt#L32

ksdrummer commented 5 months ago

Hey I'm just here because I received an update on this thread. I don't use this app anymore (because of the limitations), and I didn't answer before because I felt Kr00ked answer was slightly disrespectful. But anyways...

You don't want to change the limitations of your app, and it's totally fine. You're making your metronome the way you want. Good for you !

However, as a professional musician, I need my metronome to go below 10BPM. Other metronomes like the excellent chubby click do the job so no problem, however no need to answer our suggestion to improve your app the way you did.

No hard feelings though, I wish you the best with this promising metronome (it looks good at least).