Kr1S-D / UltimateAntibotRecoded

Just another antibot plugin =)
34 stars 6 forks source link

The priority of blacklist and whitelist #18

Closed a1375625918 closed 1 year ago

a1375625918 commented 1 year ago

The operator added a blacklisted IP to whitelist. But this IP was still blocked until it's removed from blacklist.

I guess blacklist takes priority so whitelist has no effect when an IP exists in both lists. However, the green [WHITELIST] button from /uab check <id> in game makes me feel that the blacklisted IP will be allowed simply by executing /uab whitelist add <IP> suggested by that green button. Things may become more reasonable if IPs in both lists are finally allowed (give whitelist higher priority), or at least operators should be asked to remove the existing blacklist record when adding IPs to whitelist.

Kr1S-D commented 1 year ago

It would be more incoming check for any bot trying to connect so it would slow down the server, when adding an IP to the whitelist it would have to be removed from the blacklist unless there are secondary checks that still blacklist it (VPN, Invalid Name )

a1375625918 commented 1 year ago

Do you mean that checking whitelist first for every connection will affect performance? Sorry I didn't take it into consideration.

Therefore, just check blacklist when using /uab whitelist add . If an operator is trying to add a blacklisted IP to whitelist then, he may receive a tip about removing blacklist records.

Kr1S-D commented 1 year ago

ok, it will be added in the next version thanks for the report!

Kr1S-D commented 1 year ago

fixed in the code, it will be available in the next official update