search

Kragrathea / OctoPrint-PrettyGCode

114 stars 22 forks source link

Feature request: Show 'Load GCode visualizer' button #23

Closed Stretch96 closed 4 years ago

Stretch96 commented 4 years ago

When the GCode file is over the 'GCode visualizer file size threshold' setting, PrettyGCode doesn't display anything until the user goes to the 'GCode Viewer' tab, and accepts to load the file

Having the button to load the file within the PrettyGCode tab will prevent users wondering why it's not showing anything

Kragrathea commented 4 years ago

I didn't know there was a size threshold. I'll look into it.

sr1329 commented 4 years ago

You could change the values in GCode Visualizer settings. Using 50MB has worked for me.

Kragrathea commented 4 years ago

Increasing the size is a good workaround. But PrettyGCode should do a better job handing the failure. I need to dig into how the built in gcode viewer handles it to figure out how to tie into it.

Kragrathea commented 4 years ago

Actually I don't think this is a bug anymore. I just tried it and the model showed up even though I didn't accept the size warning. The model just takes a long time to load.

If you can still reproduce this let me know. Otherwise I will close soon.