search

KraigM / HomeBridgeController

Provides a simplified UI for controlling your HomeBridge
88 stars 7 forks source link

Retitle buttons : Save / Discard Changes #5

Closed epheterson closed 8 years ago

epheterson commented 8 years ago

The words 'Upload' and 'Revert' do make sense, but only after sitting and pondering for a moment. For example, there is no file actually being 'uploaded.'

Save Changes and Discard Changes may be clearer strings to use.

KraigM commented 8 years ago

I see where you are coming from. I was just worried about people being confused when the "save" fails because they lost connection to the homebridge.

epheterson commented 8 years ago

The popup seems to take care of that situation nicely.

As a side-note, the popup would be nicer if it appeared within the UI instead of atop the UI, like this : disk-utility-first-aid

(Should I file a separate bug?)

KraigM commented 8 years ago

@epheterson On that last comment, which popup are you talking about?

epheterson commented 8 years ago
  1. Start HomeBridgeController w/out having homebridge running
  2. Click 'Upload Config'

That popup :)

KraigM commented 8 years ago

As part of #4 these buttons are being replaced with menu items as well as being renamed.

Upload Config is now just Save to better fit with the integration into the document system (in fact I have no choice without hacking in a way to override it lol). To go along with that, Revert Config is now Reload from Hub.

Since Revert To Last Saved is already built into the document versioning system (integrated with #4), the only real use for redownloading the config from the hub was when you manually changed it without HBC. Given that plus the fact that Save already has a common shortcut (cmd+S), I don't really see the need for the toolbar buttons anymore so I'm disabling the toolbar for the time being.

Does that all sound good?

epheterson commented 8 years ago

Sounds good!

KraigM commented 8 years ago

Cool. Completed and will be in next release (0.4.0)