Incorrect spec for Api.modify_webhook

Kraigie / nostrum

Elixir Discord Library

https://kraigie.github.io/nostrum/

MIT License

591 stars 125 forks source link

Incorrect spec for Api.modify_webhook #612

Open malmz opened 1 week ago

malmz commented 1 week ago

The spec for Api.modify_webhook does not match discords documentation

name and avatar are required while they should be optional
channel_id is missing .

https://discord.com/developers/docs/resources/webhook#modify-webhook

Th3-M4jor commented 1 week ago

Nostrum's API module is mostly a low level pass-through to discord with minimal transformations applied before encoding the payload into JSON. As such it kinda assumes you're using it in tandem with Discord's own API docs, so any specs you see are usually little more than a guideline.

PRs to fix any inconsistencies are always welcome though 🙂

broman commented 1 week ago

Understood, thanks Th3-M4jor!

broman commented 1 week ago

I love Nostrum!