search

KrailOrg / krail

Rapid web app framework using Vaadin 8 integrated with Guice and Shiro
50 stars 19 forks source link

Empty root url disallowed - is that necessary? #731

Open davidsowerby opened 5 years ago

davidsowerby commented 5 years ago

Currently a route root (!) is required, so for example:

com.example/myapp/#p

will work, but this will not work as a page:

com.example/myapp/#

This was clearly a deliberate choice but is it necessary?

Caused by: uk.q3c.krail.core.navigate.sitemap.SitemapException: Either the rootURI or the uri must be non-empty at uk.q3c.krail.core.navigate.sitemap.DirectSitemapModule.addEntry(DirectSitemapModule.kt:104) at uk.q3c.krail.core.navigate.sitemap.DirectSitemapModule.addEntry$default(DirectSitemapModule.kt:93) at uk.q3c.krail.testapp.view.SimplePagesModule.define(SimplePagesModule.kt:37) at uk.q3c.krail.core.navigate.sitemap.DirectSitemapModule.configure(DirectSitemapModule.kt:55) at com.google.inject.AbstractModule.configure(AbstractModule.java:62) at com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:340) at com.google.inject.spi.Elements.getElements(Elements.java:110) at com.google.inject.internal.InjectorShell$Builder.build(InjectorShell.java:138) at com.google.inject.internal.InternalInjectorCreator.build(InternalInj