Upgrade to Vaadin-Vertx Version 1.0.0

KrailOrg / krail

Rapid web app framework using Vaadin 8 integrated with Guice and Shiro

50 stars 19 forks source link

Upgrade to Vaadin-Vertx Version 1.0.0 #761

Open Dudeplayz opened 5 years ago

Dudeplayz commented 5 years ago

Hi, It would be nice to upgrade the vaadin-vertx libary to the newest version. Some adjustments are necessary. I would do it in a pull request but i am not that good in kotlin.

A vaadin version upgrade could be also useful.

davidsowerby commented 5 years ago

I would be happy to accept a PR in Java rather than Kotlin, but in this case that probably is not practical.

I have not yet looked at what changes need to be made. Could you share what you think would be required?

Dudeplayz commented 5 years ago

Mainly the sockjs implementation is now seperated from the project to support vaadin8 and vaadin10 independently. Thats why some classpaths have changed which results in exceptions if the version is raised. Because my kotlin knowledge is very fresh im not sure if the pushconnection access is very different. Some things have changed internally but the API could be mostly the same.