search

KrakenTyio / eid-applet

Automatically exported from code.google.com/p/eid-applet
Other
0 stars 0 forks source link

PcscEid.getLanguageId() compares sublanguage for FR and DE #78

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Set Locale to fr_BE or de_BE
2. Connect an SPR
3. call verifyPin or anything else requiring PIN entry

(or launch eid-viewer, which uses National sublanguages), set language to 
French or German and Verify PIN on an SPR)

What is the expected output? What do you see instead?

Expect SPR to display PIN prompt in French for Locale of fr_BE or German for 
Locale of de_BE. Instead, PIN prompt is English except for Locale nl_BE

What version of the product are you using? On what operating system?

1.0.5-SNAPSHOT

Please provide any additional information below.

PcscEid.getLanguageId() compares to the default sublanguage, by using 
Locale.equals() except for "nl" where only language is compared (obviously, 
since there is no constant for DUTCH in the standard Locale class)

Since createPINVerificationDataStructure() ends up sending for the default 
sublanguage, regardless of the actual one anyway, I think it would be more 
consistent for getLanguageId() to ignore the sublanguage in its comparisons, as 
well.

Patch attached.

Original issue reported on code.google.com by fr4...@gmail.com on 25 Jul 2012 at 10:03

Attachments:

GoogleCodeExporter commented 8 years ago 
Will not fix this anymore in the eID Applet => Commons eID.

Original comment by frank.co...@gmail.com on 17 Oct 2012 at 12:37