search

Kralizek / AWSSecretsManagerConfigurationExtensions

This repository contains a provider for Microsoft.Extensions.Configuration that retrieves secrets stored in AWS Secrets Manager.
MIT License
231 stars 44 forks source link

Secrets that look like Json Arrays or Objects (but are not) do not work #48

Closed mirkogeffken closed 3 years ago

mirkogeffken commented 3 years ago

Secrets that look like arrays or objects (start with "[" or "{"), but are not actually Json do not work. e.g. a secret being "{THIS IS NOT AN OBJECT" or "[THIS IS NOT AN ARRAY" do not work. There is a function in the source checking for the value starting with these called IsJson, which is probably too simplistic a check (maybe JToken.Parse and check for JsonReaderException instead)?

Kralizek commented 3 years ago

Hi @mirkogeffken, thank you for opening this issue. Do you want to give a try at tackling this issue?