Kralizek / AWSSecretsManagerConfigurationExtensions

This repository contains a provider for Microsoft.Extensions.Configuration that retrieves secrets stored in AWS Secrets Manager.
MIT License
231 stars 44 forks source link

Document that `AcceptedSecretArns` supports friendly names & partial ARN's #59

Closed kpenergy closed 3 years ago

kpenergy commented 3 years ago

The SecretsManagerConfigurationProviderOptions.AcceptedSecretArns property's name suggests that it only supports full ARN's. However, the value's specified here are used as the SecretId in a GetSecretValueRequest, which means they can be:

It would be good if either:

Kralizek commented 3 years ago

Hi @kpenergy

Thanks for opening this issue. Right now I don't have the time to invest in this library but I welcome contributors to propose changes with PRs: this applies both to the source code and to the documentation.

kpenergy commented 3 years ago

@Kralizek No worries, I'll try and submit an update to the docs over the next few days.

devklick commented 3 years ago

Created PR #60 to update docs and comments