search

Kralizek / AWSSecretsManagerConfigurationExtensions

This repository contains a provider for Microsoft.Extensions.Configuration that retrieves secrets stored in AWS Secrets Manager.
MIT License
219 stars 43 forks source link

Replace Newtownsoft with System.Text.Json #68

Closed goenning closed 2 years ago

goenning commented 2 years ago

If I contributed with a PR to replace newtownsoft json with System.Text.Json, would you accept it?

Kralizek commented 2 years ago

This could be an interesting development. I wonder if replacing is the right way to go. An alternative would be to mirror the package with support for STJ instead of NSJ. just thinking aloud.

goenning commented 2 years ago

But in that case, what would be the benefits of using NSJ instead of STJ though? Microsoft has been moving all their packages to use STJ, it's faster and comes pre-installed on .net core 3+.

From my perspective, removing NSJ from this packages means there's one less dependency on .net apps: smaller builds/images, faster deployments, etc.

Kralizek commented 2 years ago

I see your point and I agree with you. I'm just trying to find a way to hold from releasing a major version unless it's really needed.

jcanady20 commented 2 years ago

I have a working PR that addresses this. https://github.com/Kralizek/AWSSecretsManagerConfigurationExtensions/pull/71

Kralizek commented 2 years ago

Closing since it was fixed with #71