search

Kralizek / AWSSecretsManagerConfigurationExtensions

This repository contains a provider for Microsoft.Extensions.Configuration that retrieves secrets stored in AWS Secrets Manager.
MIT License
231 stars 44 forks source link

Logging #86

Open bencyoung-Fignum opened 1 year ago

bencyoung-Fignum commented 1 year ago

Hi,

It would be great if we could add logging for certain situations (on request, , missing secrets, if JSON parsing fails etc).

Would you accept a PR? If so would you want it with a simple Action callback in the options, or would you be happy with a way to bind an ILogging implementation somehow?

Thanks

Kralizek commented 1 year ago

I'm currently too busy to work on the library but I welcome PRs under the understanding that I cannot promise when I will have time to look at it.

Anyway, you can use closures to inject a logger in methods that are used for configuration. I know it's not enough but it could be a starter to help you troubleshooting your issue.