KrashKart / pe

0 stars 0 forks source link

Duplicate Phone Numbers and Emails are allowed #6

Open KrashKart opened 1 week ago

KrashKart commented 1 week ago

Expected: It is reasonable to assume that doctors cannot have the same phone numbers or emails.

Actual: It is possible to add doctors with the same phone numbers and emails: image.png

Steps to duplicate:

  1. Assume contact list is empty
  2. Enter add-doctor n/John Tan p/88881111 a/Marsiling e/hey@gmail.com s/Ortho
  3. Enter add-doctor n/John Lim p/88881111 a/Bedok e/hey@gmail.com s/Ortho

Suggestion: Perhaps you could disallow duplicate phone numbers across doctors. I feel that for patients it is ok since young patients tend to use their parents' numbers or emails but for doctors, I can assume that they are rich enough to get their own SIM card and emails.

If not, at least include a warning that there are duplicate fields so the user knows in the event of an intended entry.

nus-se-bot commented 1 week ago

Team's Response

As a team, we agree that this is indeed a feature flaw.

Regarding phone number, we made the decision to allow for different contacts to have the same phone number since young patients tend to use their parents' numbers and emails. Though this ended up being implemented for both doctors and patients.

However, while we agree that this is a valid issue, we believe the current app can still function normally as intended and that fixing it is less important than the work done in v1.6. Hence we believe the issue is out of scope for this iteration.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]