search

Krassmus / LernmodulePlugin

2 stars 9 forks source link

Bug Fix: Calculation of attempt duration was off by a factor of 10 #5

Closed annyanich closed 2 years ago

annyanich commented 2 years ago

Hi Rasmus! Thomas Hellkamp and I were just looking into extending your plugin to re-implement certain H5P modules using vue. While we were checking the code out, we noticed there was a visual bug when displaying the duration of module attempts. Here is a pull request to fix it :)

All the best, Ann

Krassmus commented 2 years ago

Hi Ann! That sounds interesting. Nico just told me about the backgrounds of this project. It is definitely a good idea to get rid of that incompatability problems with H5P. I granted you writing permissions to this whole repository. So you don't always need to start a pull request and wait for my response.