search

KratosMultiphysics / CoSimIO

Small standalone tool for interprocess communication in CoSimulation contexts for coupling and exchanging data between different solvers or other software-tools.
https://kratosmultiphysics.github.io/CoSimIO/
Other
14 stars 4 forks source link

Build script has debug as the build type #359

Closed pooyan-dadvand closed 1 year ago

pooyan-dadvand commented 1 year ago

The scripts/build.sh is setting build type to debug in the release source. I would suggest to change it to release.

loumalouomega commented 1 year ago

@philbucher I would agree with this

loumalouomega commented 1 year ago

@philbucher I can confirm this happens in Windows, can you make me developer so I can do a PR without doing a fork?

philbucher commented 1 year ago

@philbucher I can confirm this happens in Windows, can you make me developer so I can do a PR without doing a fork?

done, thx!

philbucher commented 1 year ago

(added you to the CoSimTeam, I think it makes sense for you)