search

KratosMultiphysics / Examples

All benchmarks, examples and applications cases to be run by Kratos. Note that unit tests are in Kratos repository and NOT here
https://kratosmultiphysics.github.io/Examples/
43 stars 40 forks source link

Adding FSI Turek Benchmark to CoSim Examples #133

Closed juancamarotti closed 9 months ago

juancamarotti commented 9 months ago

Adding one new FSI example to the CoSimulationApplication (FSI Turek example)

matekelemen commented 9 months ago

@juancamarotti can you plz update me about what the problem with the coupling convergence was?

juancamarotti commented 9 months ago

@matekelemen the ALE boundary conditions for the mesh motion solver were imposed incorrectly in the ProjectParametersCFD.json

matekelemen commented 9 months ago

alright, can you please give me a diff on the setting that solved the issue?

juancamarotti commented 9 months ago

@rubenzorrilla I have already changed the fluid element formulation and it is working properly! Could you review it?

rubenzorrilla commented 9 months ago

@rubenzorrilla I have already changed the fluid element formulation and it is working properly! Could you review it?

Looks OK. I've nothing else to add.

juancamarotti commented 9 months ago

@rubenzorrilla I have already changed the fluid element formulation and it is working properly! Could you review it?

Looks OK. I've nothing else to add.

Could you please approve the pull request so that I can merge it to the master branch? Thank you very much in advance

rubenzorrilla commented 9 months ago

@rubenzorrilla I have already changed the fluid element formulation and it is working properly! Could you review it?

Looks OK. I've nothing else to add.

Could you please approve the pull request so that I can merge it to the master branch? Thank you very much in advance

There is no branch protection in the Examples repo so you can merge whenever you want.