KratosMultiphysics / GiDInterface

The graphical user interface of Kratos for GiD. Featuring CFD, CSM, DEM, PFEM, etc
Other
30 stars 16 forks source link

[PFEM-Fluid] new cut-PFEM element and settings #969

Open AFranci opened 4 months ago

AFranci commented 4 months ago

This PR introduces the cut-PFEM element among the options to chose. The order and name of elements appearing in the interface has been also changed. Finally, penalty_coefficient now appears as an input parameter of the solver.

AFranci commented 4 months ago

Hi Javi! Please, check this PR and tell me if you notice something to change. Sometimes when I open more times the options of the elements I get this error/warning

image

I am not sure that depends on the changes I am doing in this PR.

AFranci commented 4 months ago

Furthermore, I would like to add a new change but I may need your help. When the user has selected TwoStepUpdatedLagrangianVPFluidCutFemElement2D or TwoStepUpdatedLagrangianVPFluidCutFemElement3D in the interface, I would like to have automatically the following in the ProjectParameters.json:

"meshing_domains" : [{ "model_part_name" : "Body1", "python_module" : "fluid_meshing_domain", "alpha_shape" : 1.3, "meshing_strategy" : { "python_module" : "cut_pfem_fluid_meshing_strategy", "remesh" : true, "refine" : true, "transfer" : false, "reference_element_type" : "TwoStepUpdatedLagrangianVPFluidCutFemElement3D", "reference_condition_type" : "CompositeCondition3D3N" }

Instead of

"meshing_domains" : [{ "model_part_name" : "Body1", "python_module" : "fluid_meshing_domain", "alpha_shape" : 1.3, "meshing_strategy" : { "python_module" : "fluid_meshing_strategy", "remesh" : true, "refine" : true, "transfer" : false, "reference_element_type" : "TwoStepUpdatedLagrangianVPFluidElement3D", "reference_condition_type" : "CompositeCondition2D2N" },

Do you think it is possible?

Thank you for your help!

jginternational commented 3 months ago

Hi @AFranci

The first part, if you have tested it and works, it's fine.

For the second query, I could not reproduce it, so send me more information if it's still a problem

For the third query, as you can see in kratos.gid\apps\PfemFluid\write\writeProjectParameters.tcl Line 299:304:307 the reference_element_type is set by tcl, so the answer is YES, it is possible to change it, BUT:

But I don't know if that is the expected behaviour

jginternational commented 1 month ago

@AFranci what is the status of this PR?