search

KratosMultiphysics / Kratos

Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.
https://kratosmultiphysics.github.io/Kratos/
Other
1.04k stars 246 forks source link

[Question] What is kratos_space.h? #10107

Open loumalouomega opened 2 years ago

loumalouomega commented 2 years ago

Description

Today I realized that we have an implementation (newer and using parallel utilities instead of plain OMP) called kratos_space.h:

https://github.com/KratosMultiphysics/Kratos/blob/master/kratos/spaces/kratos_space.h

But this implementation is only used in the corresponding test, and is not called in anywhere except that place. I assume the idea is to replace the old and not up-to-date ublas_space.h:

https://github.com/KratosMultiphysics/Kratos/blob/master/kratos/spaces/ublas_space.h

But if the idea is that, why there is no PR replacing them? (https://github.com/KratosMultiphysics/Kratos/search?q=kratos_space.h+is%3Apr&type=issues). So I assume the idea is to remove the old ublas_space.h and replace it with kratos_space.h.

@philbucher and @RiccardoRossi do you know what is the status of this?

Scope

philbucher commented 2 years ago

it is the new one for the Kratos CSR-matrices

However most probably a new B&S is needed for it, which will then be also compatible with MPI

loumalouomega commented 2 years ago

it is the new one for the Kratos CSR-matrices

However most probably a new B&S is needed for it, which will then be also compatible with MPI

So, do we need to update the ublas_space.h to use ParallelUtilities?, or will we replace directly once the Kratos CSR-matrices is completed and therefore is meaningless to update it?

philbucher commented 2 years ago

in theory it will be eventually replaced, but this might take some more time hence I guess it can be updated if there is free capacity