search

KratosMultiphysics / Kratos

Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.
https://kratosmultiphysics.github.io/Kratos/
Other
1k stars 243 forks source link

[SwimmingDem] Chien Drag Test Analysis Failing in Nightly #11931

Open roigcarlo opened 7 months ago

roigcarlo commented 7 months ago

Description @jgonzalezusua Seems that chien_drag_test_analysis.py is causing the nightly build to fail. Could you take a look? Pinging you because we have no one assigned to Swimming dem and the test was last touched by you 3 months ago.

Sample of the failing report: https://github.com/KratosMultiphysics/Kratos/actions/runs/7447864857/job/20261002872?pr=11930

Traceback (most recent call last):
  File "/__w/Kratos/Kratos/bin/Release/applications/SwimmingDEMApplication/tests/DragTestFactory.py", line 26, in test_execution
    self.test.Run()
  File "/__w/Kratos/Kratos/bin/Release/KratosMultiphysics/SwimmingDEMApplication/swimming_DEM_analysis.py", line 205, in Run
    super().Run()
  File "/__w/Kratos/Kratos/bin/Release/KratosMultiphysics/analysis_stage.py", line 50, in Run
    self.Finalize()
  File "/__w/Kratos/Kratos/bin/Release/applications/SwimmingDEMApplication/tests/drag_tests/chien_law/chien_drag_test_analysis.py", line 34, in Finalize
    self.CheckValues(x_vel)
UnboundLocalError: local variable 'x_vel' referenced before assignment
rubenzorrilla commented 6 months ago

@KratosMultiphysics/dem @jgonzalezusua is this still active?

jgonzalezusua commented 6 months ago

Sorry for the late response, I have not check it. It should work since it is in master branch. Anyway, it is better to deactivate this test temporary. It seems is something related with the mesh and not with the calculation.