KratosMultiphysics / Kratos

Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.
https://kratosmultiphysics.github.io/Kratos/
Other
985 stars 242 forks source link

[GeoMechanicsApplication] Implement well constitutive behaviour for line pressure element #12323

Open mnabideltares opened 2 months ago

mnabideltares commented 2 months ago

Description:

To enhance our computational model for simulating high capacity heat storage systems, we need to implement a pressure "wel/filter" element on top of the existing pressure line element. The pressure filter element will enable us to model the behavior of heat storage under the ground, accounting for their heat exchange processes. This addition is crucial for achieving realistic simulations of heat storage systems and optimizing their performance.

Acceptance Criteria:

  1. Identify the appropriate mathematical formulation for the pressure filter element.
  2. Develop the necessary code changes to integrate the pressure filter element with the existing pressure line element
  3. Add test cases to validate the accuracy and stability of the implemented pressure filter element
  4. Documentation for the test cases
rfaasse commented 3 weeks ago

To be looked into before next refinement by @rfaasse

rfaasse commented 4 days ago

Had a look into the PR, it is quite limited in scope and size, so should not be too much work to review and adjust. There are some possibilities to include/extend the functions we have in transport_equation_utilities to calculate the biot moduli (also making it easier to unit test this). What is still missing are the integration tests for the line elements (similar to the tests for the thermal well element).