Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.
The fix from #12419 in fact was not actually solving the problem I found, after analyzing the logic I used to implement the actual search I realized that I was checking if a BB was defined and if not providing an empty one, but this originates a corner case and the threshold is not applied we have a BB consisting in only one point, and in the orginal logic that was corrected in #12419 I guess that instead of && i wanted to use ||. So I decied just to check if the threshold is positive and that way Ican avoid checks and simplify logic.
📝 Description
The fix from #12419 in fact was not actually solving the problem I found, after analyzing the logic I used to implement the actual search I realized that I was checking if a BB was defined and if not providing an empty one, but this originates a corner case and the threshold is not applied we have a BB consisting in only one point, and in the orginal logic that was corrected in #12419 I guess that instead of
&&i wanted to use||. So I decied just to check if the threshold is positive and that way Ican avoid checks and simplify logic.🆕 Changelog