KratosMultiphysics / Kratos

Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.
https://kratosmultiphysics.github.io/Kratos/
Other
985 stars 242 forks source link

[General] Output no longer outputs the initial conditions (i.e. time = 0 ) #12453

Open mcgicjn2 opened 3 weeks ago

mcgicjn2 commented 3 weeks ago

Some time ago we noticed that after a commit that the initial conditions are not written to file. i.e. time = 0.

Although we understand this is not a necessity and should be known by a user as they input it however from our perspective it has 2 purposes:

  1. To clarify that the correct calculation processes are correct.
  2. To provide that output for GUI formats.

@mnabideltares Can you potentially track down the commit where this changed ? #11509 is the commit where this occurred

Was this removed by mistake or design ?

mnabideltares commented 3 weeks ago

It is caused by: c3ed8fd - Merge pull request #11509 from KratosMultiphysics/core/controllers/temporal_controller 5 Sep 2023 12:16

matekelemen commented 2 weeks ago

I'm on holiday, but @sunethwarna might also be able to help you out with it.

sunethwarna commented 2 weeks ago

Hi, is it happening in the vtk_output_process?

mnabideltares commented 18 hours ago

Hi, is it happening in the vtk_output_process?

@sunethwarna Sorry for late reply. I was on holiday. Thank you for looking in this issue. It seems it also occurs in the vtk output.