search

KratosMultiphysics / Kratos

Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.
https://kratosmultiphysics.github.io/Kratos/
Other
985 stars 242 forks source link

Kratos rom manager parameters bugs #12463

Open SADPR opened 2 weeks ago

SADPR commented 2 weeks ago

Pull Request Description

Overview

This pull request addresses three small "bugs" or details in the ROM Application.

Changes Made

  1. Removal of Unnecessary Parameter:

    • File: applications/RomApplication/python_scripts/hrom_training_utility.py
    • Description: Removed the root_model_part parameter from the GetConditionIdsNotInHRomModelPart function call as it was not required.

  2. Addition and Setting of Default Parameters:

    • File: applications/RomApplication/python_scripts/rom_manager.py
    • Description: Added missing settings to the ROM manager and set default values to ensure proper configuration. The settings added include parameters for element and condition selection, visualization, projection strategy, and more.

  3. Suppression of TensorFlow Logs:

    • File: applications/RomApplication/python_scripts/rom_nn_trainer.py
    • Description: Added environment variables and logger settings to suppress TensorFlow logs. This change prevents the printing of TensorFlow informational messages, reducing log clutter and focusing on essential error messages only.

I am making this a single PR because the changes are very small.