[Core] Fix Extrapolation in `Table::GetDerivative`

KratosMultiphysics / Kratos

Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.

https://kratosmultiphysics.github.io/Kratos/

Other

985 stars 242 forks source link

[Core] Fix Extrapolation in `Table::GetDerivative` #12471

Open matekelemen opened 2 weeks ago

matekelemen commented 2 weeks ago

Table::GetValue continues on the last (or first) slope if the input value is out of bounds, but Table::GetDerivative returns 0 in these regions.

This PR makes the behaviour of Table::GetDerivative consistent with Table::GetValue.

philbucher commented 1 week ago

can you add a test please?

avdg81 commented 1 week ago

It has been fixed by #12477 (thanks to @sunethwarna for reviewing and approving).