search

KratosMultiphysics / Kratos

Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.
https://kratosmultiphysics.github.io/Kratos/
Other
1.02k stars 245 forks source link

[Core] Introduce PointerComparor and remove DofPointerComparor #12509

Open sunethwarna opened 3 months ago

sunethwarna commented 3 months ago

📝 Description This PR removes the redundant DofPointerComparor because, the operators for Dof<double> is nicely done in the dof.h. This PR introduces more general PointerComparor, which uses the TDataType::operator== to compare. So, if someone was using (atleast I did not find any use cases in the master) the DofPointerComparor, they can easily change and use PointerComparor. The test was changed accordignly.

🆕 Changelog

sunethwarna commented 3 months ago

The failure in DamApplication is unrelated to this. It is failing because, one of the variables which is being used is not included in the solution step variables list. I am not sure who to tag. Any ideas @roigcarlo ?

roigcarlo commented 2 months ago

On it.

pooyan-dadvand commented 2 months ago

The implementation is ok for me. Waiting for the unit tests to approve