KratosMultiphysics / Kratos

Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.
https://kratosmultiphysics.github.io/Kratos/
Other
1.03k stars 245 forks source link

Fluid Characteristic Utilities CFL condition #8624

Closed pau-mar closed 3 years ago

pau-mar commented 3 years ago

Description In fluid_characteristic_numbers_utilities.cpp the computation of the CFL number in done taking into account the velocity of the fluid, so that the condition is only on the velocity. Should not the CFL contition take into account the sound velocity as well? That should be more appropiate when dealing with weakly compressible flows.

dcagritann commented 3 years ago

Hello @pau-mar,

> Should not the CFL condition take into account the sound velocity as well?

As far as I know, it is only the case for compressible flows. For incompressible flows, the basic definition of the CFL condition suffices. However, if one is dealing with compressible flows, I'd agree that the current version of the computation of CFL should be modified to take into account the compressible flows. Regards

rubenzorrilla commented 3 years ago

Closing as this was solved in #9133 .