operator[] , operator() and iterators in Geometry should not be virtual!!

KratosMultiphysics / Kratos

Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.

Other

1.01k stars 244 forks source link

Description By profiling code we (well @maceligueta ) discovered that the access operators to the nodes of the geometry were recently made virtual. For a simple element (in implicit!) this means around 5% of the total execution time. That would be much more in explicit.

the change was introduced to allow overriding the operators in brep_geometry.

the point is how to get rid of this without breaking (at least not too much) the brep usage.

Scope any time one uses the geometry

To Reproduce any use of operator [] () or of the iterators of a geometry

Expected behavior remove the virtual from the base class

Environment any

KratosMultiphysics / Kratos

operator[] , operator() and iterators in Geometry should not be virtual!! #8826