Future improvements - Githubissues

philbucher commented 4 years ago

This issue is a collections of ideas & thoughts for future improvements of the Plugin

GUI

[x] choose a unit-testing framework => probably with QtTest => see http://johnnado.com/pyqt-qtest-example/
[x] implement Application-testing (import the Qt-things from qtsalome or directly?) => from Qt, is cleaner
[x] unhandled exceptions should open a messagebox => check if this is already done natively
[ ] stop statusbar timers https://stackoverflow.com/a/21081371

[ ] use python f-strings (python 3.6!)
[ ] once done on the Kratos-side: Use latest docker container with Kratos (Wheels should not be used since they don't have the latest version, the docker-image gets rebuilt every night!)
[ ] Add tests for the tui-examples => requires ReadMdpa bcs I don't want to store the (big) mdpa-files from the examples => the idea is to compare only num elems etc and the ModelPart hierarchy
[ ] use lazy evaluation for logger
[x] test logging with assertLogs
[ ] Add log level for TIMING (between DEBUG and INFO)

[ ] Add a config file where options can be stored. This should be a json file in the root-dir (or maybe the .config dir in Linux?) of the Plugin. Probably load those into a py-file that can be accessed from everywhere => then it will no longer be necessary to temper with env-variables
[ ] Implement ReadMpda => needed to importing an mdpa and for testing
[ ] Create a mesh from ModelPart
[x] ~import GiD geo file and create geometry from it. => for this the GiD-project needs to be saved as Ascii => not possible right now since Salome doesn't expose the creation of NURBS entities~
[ ] maybe created ModelParts from different Main-Meshes? => think turbine which has multiple parts!
[ ] automatically switch orientation of faces and volumes in case it is wrong. Otherwise it will not work in Kratos. => see this branch
[ ] once GUI is there: add possibility to launch Kratos from GUI => subprocess
[ ] check why the logger prints are delayed while print works fine => might have sth to do with execute_in_salome and how the Popen is used => this could be related
[ ] get batch mode working in Windows. Preliminary tests using what is explained here were not successful

[ ] before doing anything in this direction some benchmarks need to be defined
[ ] in GeometriesIO: check if overlapping IDs exist for already existing entities. If not then new entities can be added without checking if an entity was already created from this geom-entity.
[ ] Using __slots__ in the ModelPart => see this branch
[ ] using parallel-processing when adding entities in the GeometriesIO
[ ] using parallel processing when getting entities from Salome-Mesh. See here. => check if accessing Salome is threadsafe!!!

loumalouomega commented 3 years ago

Just to mention last week the latest version of Salome was released FYI

philbucher commented 3 years ago

thx didn't see this will add it to the CI asap