KrauseFx / overkill-for-mac

Stop iTunes from opening when you connect your iPhone
https://krausefx.com
Other
516 stars 26 forks source link

brew cask install -> brew install #29

Closed markcerqueira closed 2 months ago

markcerqueira commented 1 year ago

~ brew cask install overkill Error: brew cask is no longer a brew command. Use brew <command> --cask instead.

xrubioj commented 1 year ago

Shouldn't this be brew install --cask overkill instead?

markcerqueira commented 1 year ago

@xrubioj I don't frequent HackerNews (so I'm not an elite developer) but this worked fine for me:

~ brew install overkill
Running `brew update --auto-update`...
==> Auto-updated Homebrew!
Updated 5 taps (robotsandpencils/made, homebrew/bundle, homebrew/cask-fonts, homebrew/core and homebrew/cask).

You have 37 outdated formulae and 1 outdated cask installed.

==> Downloading https://github.com/KrauseFx/overkill-for-mac/releases/download/1.0/Overkill.zip
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/100130108/6f6e6564-d2d8-11e7-8bec-8f0b37fff767?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20230425%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20230425T165515Z&X-Amz-Expires=300&X-Amz-Signature=3b576d313593422e92e3a33c222dc6a41540e8bc5
######################################################################################################################################################################################################################################################### 100.0%
==> Installing Cask overkill
==> Moving App 'Overkill.app' to '/Applications/Overkill.app'
🍺  overkill was successfully installed!

I see there is another PR open which does something similar to what you're suggesting. My guess is under the hood it all works the same but could break in the future?

xrubioj commented 1 year ago

TBH I don't know what the mention to HackerNews is all about, but my reply basically was following the instructions from HomeBrew in your original message:

Use brew --cask instead

I don't know the implications of not adding --cask have regarding future-proofing it.