Krazick / 18XX-Game-Engine

18XX Game Engine
MIT License
2 stars 0 forks source link

Unable to sell more than 1 certificate at a time in 1856. #211

Closed Krazick closed 1 year ago

Krazick commented 1 year ago

1856 when attempting to sell Shares of Stock it should not allow for the remaining shares in the hand to not exceed the Shares bought in the current Stock Round. The Game seems to prevent the sale of more than 1 share at a time, with reason, that share bought the current stock round were selected to be sold.

Krazick commented 1 year ago

For 1856, the rules do not allow a player to buy a certificate and immediately sell it. In our group this is called a "Touch Pass" since in 1830 this is allowed. A player buys a single certificate of a floated company from the Bank Pool and sells it immediately, driving the Stock Price down a not (unless at the bottom of Market). And the player only needs to have the cash to buy at the current price available, and the player is not at the cert limit.

The bug in the Portfolio was trying to find the Company Abbrev that was being sold. It was looping through all the selected certificates for sale, and concatenating them together. It should just find any abbrev and returned it. No concatenation was needed.

The 1830 Game was not affected since the "NO-TOUCH-PASS" Flag was tested and this test was not performed.