search

Krazick / 18XX-Game-Engine

18XX Game Engine
MIT License
2 stars 0 forks source link

When a Buy Train Action is performed, the "Select Checkbox" should be Cleared, as well as when Undone #239

Closed Krazick closed 5 months ago

Krazick commented 8 months ago

When a Corporation buys a Train (from Bank, Bank Pool, or another Corporation), the 'selected' state (Select CheckBox) should ALWAYS be Cleared. As well as when a Buy Train Action is Undone, this should be Cleared as well.

This should be done in the Clear Train Effect for applying and undoing the effect.

Krazick commented 8 months ago

Fixed the Transfer Train Effect to run the 'train.clearSelection method in the ApplyEffect and UndoEffect Methods. Need to reset trains owned by the current Company so that if they were selected for upgrade, this is also reset to reshow the checkbox (it is currently removed).

Krazick commented 7 months ago

The thought was once this was cleared, then on the UNDO it would show the Buy Checkbox (or Upgrade Checkbox in the Company's Set of Trains, but this was not resolved yet.

Krazick commented 5 months ago

Having reworked the updating of the various ways buttons, and checkboxes were done for the Train Profiles, this issue looks to be resolved.